Adjust tonic::DartInvokeField to avoid direct invocation of the field. #55986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
tonic::DartInvokeField
calledDart_Invoke
. Once Dart starts enforcing entry point verification, this will fail because fields cannot be annotated as invokable. Instead, first callDart_GetField
to get the closure value in the field and then invoke that usingDart_InvokeClosure
.This is needed to enable entry point verification by default, related to the following PRs:
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.