Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tonic::DartInvokeField to avoid direct invocation of the field. #55986

Closed
wants to merge 2 commits into from
Closed

Adjust tonic::DartInvokeField to avoid direct invocation of the field. #55986

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39c583f
Do not invoke the field directly, but get the closure and invoke that.
sstrickl Oct 21, 2024
20a41bc
Merge branch 'main' into fix-dartinvokefield
sstrickl Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions third_party/tonic/logging/dart_invoke.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,15 @@ Dart_Handle DartInvokeField(Dart_Handle target,
const char* name,
std::initializer_list<Dart_Handle> args) {
Dart_Handle field = Dart_NewStringFromCString(name);
return Dart_Invoke(target, field, args.size(),
const_cast<Dart_Handle*>(args.begin()));
if (Dart_IsError(field)) {
return field;
}
Dart_Handle closure = Dart_GetField(target, field);
if (Dart_IsError(closure)) {
return closure;
}
return Dart_InvokeClosure(closure, args.size(),
const_cast<Dart_Handle*>(args.begin()));
}

Dart_Handle DartInvoke(Dart_Handle closure,
Expand Down