Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[in_app_purchase_storekit]add storekit configuration to the example app #5411

Merged
merged 2 commits into from
Dec 14, 2023
Merged

[in_app_purchase_storekit]add storekit configuration to the example app #5411

merged 2 commits into from
Dec 14, 2023

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Nov 15, 2023 •
edited
Loading

Adds the storekit test config to the example app so the example app runs with the config file by default.
This will allow adding XCUITests to the plugin.

part of flutter/flutter#138516

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@cyanglaz cyanglaz added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Nov 15, 2023
@cyanglaz cyanglaz requested a review from LouiseHsu November 15, 2023 22:51
LouiseHsu
LouiseHsu approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@LouiseHsu LouiseHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@stuartmorgan
Copy link
Contributor

test-exempt: is a test

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2023
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Nov 16, 2023

auto label is removed for flutter/packages/5411, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@cyanglaz cyanglaz added override: no versioning needed Override the check requiring version bumps for most changes autosubmit Merge PR when tree becomes green via auto submit App labels Nov 16, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2023
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Nov 16, 2023

auto label is removed for flutter/packages/5411, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@cyanglaz
Copy link
Contributor Author

Need CHANGLOG and version exempt because it is only a change in the example app's setting

@cyanglaz cyanglaz added override: no changelog needed Override the check requiring CHANGELOG updates for most changes and removed override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Nov 16, 2023
@stuartmorgan
Copy link
Contributor

There's a regression where the LUCI tests don't seem to pick up new labels on re-run anymore; merging in main should work.

@LouiseHsu LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 14, 2023
@auto-submit auto-submit bot merged commit 05ceb1c into flutter:main Dec 14, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2023
@engine-flutter-autoroll
05ceb1c [in_app_purchase_storekit]add storekit configuration to the e…
9df7bc2 
…xample app (flutter/packages#5411)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 15, 2023
@engine-flutter-autoroll
Roll Packages from 1151191 to 3f2e16b (9 revisions) (#140218)
f9ee379 
flutter/packages@1151191...3f2e16b

2023-12-15 [email protected] Swap some iOS package CODEOWNERS (flutter/packages#5667)
2023-12-14 [email protected] [in_app_purchase_storekit]add storekit configuration to the example app (flutter/packages#5411)
2023-12-14 [email protected] [camera_platform_interface] Adds support for setting the image file format (flutter/packages#5593)
2023-12-14 [email protected] [path_provider_android] Re-enable getExternalStorageDirectories test (flutter/packages#5668)
2023-12-14 [email protected] [go_router] fix(docs): typo in example extra_codec.dart (flutter/packages#5570)
2023-12-14 [email protected] [ios_platform_images] Adopt code-excerpts (flutter/packages#5682)
2023-12-14 [email protected] [camera] Fix typo "intialize" in doc comments (flutter/packages#4949)
2023-12-14 [email protected] Roll Flutter from 11a9cb7 to a51e33a (30 revisions) (flutter/packages#5680)
2023-12-14 [email protected] [two_dimensional_scrollables] Post 3.16 stable tech debt clean up (flutter/packages#5671)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@arc-yong
[in_app_purchase_storekit]add storekit configuration to the example a…
cd2d09e 
…pp (flutter#5411)

Adds the storekit test config to the example app so the example app runs with the config file by default.
This will allow adding XCUITests to the plugin. 

part of flutter/flutter#138516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouiseHsu LouiseHsu LouiseHsu approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: in_app_purchase platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyanglaz @stuartmorgan @LouiseHsu