[two_dimensional_scrollables] Post 3.16 stable tech debt clean up #5671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
override: no versioning needed
|
Override reasoning: This refactors tests internal to the package and removes redundant asserts. There is no functional change for the user. |
goderbauer
approved these changes
Dec 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 15, 2023
flutter/packages@1151191...3f2e16b 2023-12-15 [email protected] Swap some iOS package CODEOWNERS (flutter/packages#5667) 2023-12-14 [email protected] [in_app_purchase_storekit]add storekit configuration to the example app (flutter/packages#5411) 2023-12-14 [email protected] [camera_platform_interface] Adds support for setting the image file format (flutter/packages#5593) 2023-12-14 [email protected] [path_provider_android] Re-enable getExternalStorageDirectories test (flutter/packages#5668) 2023-12-14 [email protected] [go_router] fix(docs): typo in example extra_codec.dart (flutter/packages#5570) 2023-12-14 [email protected] [ios_platform_images] Adopt code-excerpts (flutter/packages#5682) 2023-12-14 [email protected] [camera] Fix typo "intialize" in doc comments (flutter/packages#4949) 2023-12-14 [email protected] Roll Flutter from 11a9cb7 to a51e33a (30 revisions) (flutter/packages#5680) 2023-12-14 [email protected] [two_dimensional_scrollables] Post 3.16 stable tech debt clean up (flutter/packages#5671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…utter#5671) Fixes flutter/flutter#136933 Fixes flutter/flutter#132782 This cleans up some TODOs in the TableView and its tests after the stable release - removes an assertion on the builder delegate bounds now that the super class handles the assertions - refactors all of the golden file tests using PaintPattern, removing all of the golden files and enabling web testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#136933
Fixes flutter/flutter#132782
This cleans up some TODOs in the TableView and its tests after the stable release
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.