-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci/various] Update for 3.19 stable #6147
Changes from all commits
7a89d5e
b4715ff
e36fa35
d24223e
bdb6afd
374872a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,7 @@ tasks: | |
script: .ci/scripts/tool_runner.sh | ||
args: | ||
- "pubspec-check" | ||
- "--min-min-flutter-version=3.10.0" | ||
- "--min-min-flutter-version=3.13.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nonblocking? Why not make this the highest patch version? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is covered in the wiki page about doing stable updates:
In practice, we've never had a case of this being a problem since we set up the legacy tests, and it means compatibility for more users on old versions. |
||
- "--allow-dependencies=script/configs/allowed_unpinned_deps.yaml" | ||
- "--allow-pinned-dependencies=script/configs/allowed_pinned_deps.yaml" | ||
always: true | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
## NEXT | ||
|
||
* Updates minimum supported SDK version to Flutter 3.13/Dart 3.1. | ||
|
||
## 2.0.11 | ||
|
||
* Fixes new lint warnings. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does most of this pr update to 3.13 but the legacy test updates to 3.16? Is the legacy test by definition only one flutter release old?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two legacy tests: N-1, and N-2. This is the N-1 test, which is by definition one release old, and the one just below is N-2, which is by definition two releases old.
(We have both main because if a package decides to drop N-2 but still support N-1, we want to make sure it doesn't accidentally uses APIs from N, but it won't be able to run the N-2 tests.)