Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci/various] Update for 3.19 stable #6147

Merged
merged 6 commits into from
Feb 16, 2024
Merged

[ci/various] Update for 3.19 stable #6147

merged 6 commits into from
Feb 16, 2024

Conversation

stuartmorgan
Copy link
Contributor

Does the steps from https://github.com/flutter/flutter/wiki/Updating-Packages-repo-for-a-stable-release to account for stable now being 3.19, and N-2 (and thus our minimum supported min version) being 3.13.

These changes are version-bump-exempt by repo policy.

@stuartmorgan stuartmorgan added the override: no versioning needed Override the check requiring version bumps for most changes label Feb 16, 2024
reidbaker
reidbaker approved these changes Feb 16, 2024
View reviewed changes
.ci.yaml
@@ -295,21 +295,21 @@ targets:
timeout: 30
properties:
target_file: analyze_legacy.yaml
channel: "3.13.9"
channel: "3.16.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does most of this pr update to 3.13 but the legacy test updates to 3.16? Is the legacy test by definition only one flutter release old?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does most of this pr update to 3.13 but the legacy test updates to 3.16? Is the legacy test by definition only one flutter release old?

There are two legacy tests: N-1, and N-2. This is the N-1 test, which is by definition one release old, and the one just below is N-2, which is by definition two releases old.

(We have both main because if a package decides to drop N-2 but still support N-1, we want to make sure it doesn't accidentally uses APIs from N, but it won't be able to run the N-2 tests.)

.ci/targets/repo_checks.yaml
@@ -19,7 +19,7 @@ tasks:
script: .ci/scripts/tool_runner.sh
args:
- "pubspec-check"
- "--min-min-flutter-version=3.10.0"
- "--min-min-flutter-version=3.13.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nonblocking? Why not make this the highest patch version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is covered in the wiki page about doing stable updates:

We generally use .0 here, not the latest hotfix, under the assumption that there are not going to be analysis-breaking changes in a hotfix.

In practice, we've never had a case of this being a problem since we set up the legacy tests, and it means compatibility for more users on old versions.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 16, 2024
@auto-submit auto-submit bot merged commit cc34b78 into flutter:main Feb 16, 2024
79 checks passed
@stuartmorgan stuartmorgan deleted the update-stable-3-19 branch February 16, 2024 17:41
@ditman
Copy link
Member

ditman commented Feb 16, 2024

Thanks for bumping this!

jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Feb 17, 2024
@jason-simmons
Manual roll Packages from c56c12d to 0af905d
8cea0c3 
0af905d [flutter_migrate] Implement lineTerminator in the MemoryStdout fake (flutter/packages#6152)
f865baf Raise gradle wrapper version of legacy project (flutter/packages#6132)
b4d8ad7 Bump github/codeql-action from 3.24.1 to 3.24.3 (flutter/packages#6142)
cc34b78 [ci/various] Update for 3.19 stable (flutter/packages#6147)
10a8b76 Roll Flutter (stable) from 4145645 to bae5e49 (1550 revisions) (flutter/packages#6145)
a36071b Roll Flutter from a628814 to d7867ca (66 revisions) (flutter/packages#6146)
@jason-simmons jason-simmons mentioned this pull request Feb 17, 2024
Merged
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 17, 2024
@jason-simmons
Manual roll Packages from c56c12d to 0af905d (#143651)
2d48ab7 
0af905d [flutter_migrate] Implement lineTerminator in the MemoryStdout fake (flutter/packages#6152)
f865baf Raise gradle wrapper version of legacy project (flutter/packages#6132)
b4d8ad7 Bump github/codeql-action from 3.24.1 to 3.24.3 (flutter/packages#6142)
cc34b78 [ci/various] Update for 3.19 stable (flutter/packages#6147)
10a8b76 Roll Flutter (stable) from 4145645 to bae5e49 (1550 revisions) (flutter/packages#6145)
a36071b Roll Flutter from a628814 to d7867ca (66 revisions) (flutter/packages#6146)
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@stuartmorgan @arc-yong
[ci/various] Update for 3.19 stable (flutter#6147)
193c1de 
Does the steps from https://github.com/flutter/flutter/wiki/Updating-Packages-repo-for-a-stable-release to account for stable now being 3.19, and N-2 (and thus our minimum supported min version) being 3.13.

These changes are version-bump-exempt [by repo policy](https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

@cbracken cbracken Awaiting requested review from cbracken cbracken is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@gmackall gmackall Awaiting requested review from gmackall gmackall is a code owner

@ditman ditman Awaiting requested review from ditman ditman is a code owner

@MitchellGoodwin MitchellGoodwin Awaiting requested review from MitchellGoodwin MitchellGoodwin is a code owner

@yjbanov yjbanov Awaiting requested review from yjbanov yjbanov is a code owner

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams jonahwilliams is a code owner

@gspencergoog gspencergoog Awaiting requested review from gspencergoog gspencergoog is a code owner

@dnfield dnfield Awaiting requested review from dnfield

@keyonghan keyonghan Awaiting requested review from keyonghan

@chunhtai chunhtai Awaiting requested review from chunhtai chunhtai is a code owner

@domesticmouse domesticmouse Awaiting requested review from domesticmouse domesticmouse is a code owner

@goderbauer goderbauer Awaiting requested review from goderbauer goderbauer is a code owner

@Piinks Piinks Awaiting requested review from Piinks

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no versioning needed Override the check requiring version bumps for most changes p: animations p: camera p: cross_file p: css_colors p: cupertino_icons p: dynamic_layouts The dynamic_layouts package p: espresso p: extension_google_sign_in_as_googleapis_auth p: file_selector p: flutter_adaptive_scaffold p: flutter_image p: flutter_lints p: flutter_markdown p: flutter_migrate p: flutter_plugin_android_lifecycle p: flutter_template_images p: go_router_builder p: go_router p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: local_auth p: metrics_center p: multicast_dns p: palette_generator p: path_provider p: pigeon p: plugin_platform_interface p: quick_actions p: shared_preferences p: standard_message_codec p: url_launcher p: video_player p: web_benchmarks p: webview_flutter p: xdg_directories platform-android platform-linux platform-macos platform-web platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartmorgan @ditman @reidbaker