[flutter_migrate] Implement lineTerminator in the MemoryStdout fake #6152
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://dart-review.googlesource.com/c/sdk/+/326761/24/sdk/lib/io/stdio.dart#380 added a `lineTerminator` field to `Stdout`. See flutter/flutter#143614
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
approved these changes
Feb 17, 2024
jason-simmons
added
the
autosubmit
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Feb 17, 2024
0af905d [flutter_migrate] Implement lineTerminator in the MemoryStdout fake (flutter/packages#6152) f865baf Raise gradle wrapper version of legacy project (flutter/packages#6132) b4d8ad7 Bump github/codeql-action from 3.24.1 to 3.24.3 (flutter/packages#6142) cc34b78 [ci/various] Update for 3.19 stable (flutter/packages#6147) 10a8b76 Roll Flutter (stable) from 4145645 to bae5e49 (1550 revisions) (flutter/packages#6145) a36071b Roll Flutter from a628814 to d7867ca (66 revisions) (flutter/packages#6146)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 17, 2024
0af905d [flutter_migrate] Implement lineTerminator in the MemoryStdout fake (flutter/packages#6152) f865baf Raise gradle wrapper version of legacy project (flutter/packages#6132) b4d8ad7 Bump github/codeql-action from 3.24.1 to 3.24.3 (flutter/packages#6142) cc34b78 [ci/various] Update for 3.19 stable (flutter/packages#6147) 10a8b76 Roll Flutter (stable) from 4145645 to bae5e49 (1550 revisions) (flutter/packages#6145) a36071b Roll Flutter from a628814 to d7867ca (66 revisions) (flutter/packages#6146)
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…lutter#6152) https://dart-review.googlesource.com/c/sdk/+/326761/24/sdk/lib/io/stdio.dart#380 added a `lineTerminator` field to `Stdout`. See flutter/flutter#143614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dart-review.googlesource.com/c/sdk/+/326761/24/sdk/lib/io/stdio.dart#380 added a
lineTerminatorfield toStdout.See flutter/flutter#143614