Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher]fix issue #25721 url_launcher: reset _currentSession only at end of browsing instead of after VC display #1010

Closed
wants to merge 2 commits into from

Conversation

MagicalTux
Copy link

this solves issue flutter/flutter#25721 by having completion code called when user presses the "Done" button (safariViewControllerDidFinish, which calls dismissViewControllerAnimated), allowing closeWebView() to work in iOS.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@MagicalTux
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@timtraversy
Copy link
Contributor

I made a similar PR for this problem at #997. Whatever one we go with this should get merged so the function can work on iOS.

@MagicalTux
Copy link
Author

MagicalTux commented Dec 31, 2018

@timtraversy

I made a similar PR for this problem at #997. Whatever one we go with this should get merged so the function can work on iOS.

Sorry I didn't see it, as I was primarily looking at bug reports in https://github.com/flutter/flutter. Hopefully either one can be merged, in the meantime I'm using a modified version locally.

Also, I created another issue regarding using safariVC to authenticate users, see flutter/flutter#25928 - I guess you may have similar needs and/or requirements

@cyanglaz cyanglaz changed the title fix issue #25721 url_launcher: reset _currentSession only at end of browsing instead of after VC display [url_launcher]fix issue #25721 url_launcher: reset _currentSession only at end of browsing instead of after VC display Feb 22, 2019
@cyanglaz
Copy link
Contributor

cyanglaz commented Mar 7, 2019

The same issue seems has been fixed by 36c56ee
I am closing the PR now. If you find the PR is needed for different issues, please feel free to reopen it.

@cyanglaz cyanglaz closed this Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants