-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Conversation
Please, when can we expect this to be merged. Please before the holidays... 🙏 |
Sorry, had some problems rebasing this, not sure why it pinged everybody for review.
This completion handles is called the moment the moment the VS finishes loading, so once the To prevent a memory leak by never setting it to nil, I've added a closure to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add CHANGLOG and pubspec updates.
This reverts commit 87143e0.
Fixing some unnoticed issues from #924. Moved the deallocation of the
currentSession
object to a closure that is called when the Safari VC is dismissed. Now it is deallocated if thecloseWebView
function is called, or if the user manually dismissed the VC.I didn't notice any Android issues while testing. I think sometimes the simulator can take a while to launch a Web View and if it takes longer than 5 seconds it appears like there is a bug, but it is working fine for me.