This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Fix null language code and no detected text bug #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
commented
Nov 16, 2018
| @@ -15,7 +15,7 @@ + (void)handleDetection:(FIRVisionImage *)image | |||
| [FLTFirebaseMlVisionPlugin handleError:error result:result]; | |||
| return; | |||
| } else if (!visionText) { | |||
| result(@[]); | |||
| result(@{ @"text" : @"", @"blocks" : @[] }); | |||
There was a problem hiding this comment.
The dart side expects a Map<dynamic, dynamic> to return.
bparrishMines
commented
Nov 16, 2018
| @@ -85,7 +85,9 @@ + (void)addData:(NSMutableDictionary *)addTo | |||
|
|
|||
| __block NSMutableArray<NSDictionary *> *allLanguageData = [NSMutableArray array]; | |||
| for (FIRVisionTextRecognizedLanguage *language in languages) { | |||
| [allLanguageData addObject:@{@"languageCode" : language.languageCode}]; | |||
| [allLanguageData addObject:@{ | |||
| @"languageCode" : language.languageCode ? language.languageCode : [NSNull null] | |||
There was a problem hiding this comment.
A crash would occur if language.languageCode was nil or NULL. This is because they can't be added to an NSDictionary.
kroikie
approved these changes
Nov 16, 2018
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
This reverts commit dea7d44.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.