Fix null language code and no detected text bug (flutter#899)

jusst-engineering · Nov 16, 2018 · 637ac55 · 637ac55
1 parent 2847d7e
commit 637ac55
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/packages/firebase_ml_vision/CHANGELOG.md b/packages/firebase_ml_vision/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.2.0+2
+
+* Fix bug with empty text object.
+* Fix bug with crash from passing nil to map.
+
 ## 0.2.0+1
 
 Bump Android dependencies to latest.

diff --git a/packages/firebase_ml_vision/ios/Classes/TextRecognizer.m b/packages/firebase_ml_vision/ios/Classes/TextRecognizer.m
@@ -15,7 +15,7 @@ + (void)handleDetection:(FIRVisionImage *)image
                     [FLTFirebaseMlVisionPlugin handleError:error result:result];
                     return;
                   } else if (!visionText) {
-                    result(@[]);
+                    result(@{ @"text" : @"", @"blocks" : @[] });
                     return;
                   }
 
@@ -85,7 +85,9 @@ + (void)addData:(NSMutableDictionary *)addTo
 
   __block NSMutableArray<NSDictionary *> *allLanguageData = [NSMutableArray array];
   for (FIRVisionTextRecognizedLanguage *language in languages) {
-    [allLanguageData addObject:@{@"languageCode" : language.languageCode}];
+    [allLanguageData addObject:@{
+      @"languageCode" : language.languageCode ? language.languageCode : [NSNull null]
+    }];
   }
 
   [addTo addEntriesFromDictionary:@{

diff --git a/packages/firebase_ml_vision/pubspec.yaml b/packages/firebase_ml_vision/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin for Google ML Vision for Firebase, an SDK that bring
   learning expertise to Android and iOS apps in a powerful yet easy-to-use package.
 author: Flutter Team <[email protected]>
 homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_ml_vision
-version: 0.2.0+1
+version: 0.2.0+2
 
 dependencies:
   flutter: