You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the helm deployment using templates instead of tiller we are hitting this issue jenkins-x/jx#3920
because jx will delete all the deployments whose labels do not match jenkins.io/chart-release=jx,jenkins.io/version!=CURRENT_VERSION to cleanup, which includes the generated primary deployment
There are several options to avoid it
flagger does not copy the labels from the canary to the primary deployment, because this is making the generated deployment look like it is part of the helm chart. Annotations are not being copied for instance. At least the chart label should probably not be there.
flagger canary object adds a spec.deployment.labels section where I can override jenkins.io/chart-release="" or add a jx-do-not-delete type of label
jx fixes it maybe not deleting something with ownerReferences or not having an annotation
I'm inclined for 1+2, do not add any label, unless explicitly set in the canary object under spec.deployment.labels
WDYT?
The text was updated successfully, but these errors were encountered:
carlossg
added a commit
to carlossg/flagger
that referenced
this issue
May 10, 2019
With the helm deployment using templates instead of tiller we are hitting this issue
jenkins-x/jx#3920
because jx will delete all the deployments whose labels do not match
jenkins.io/chart-release=jx,jenkins.io/version!=CURRENT_VERSION
to cleanup, which includes the generated primary deploymentThere are several options to avoid it
chart
label should probably not be there.spec.deployment.labels
section where I can overridejenkins.io/chart-release=""
or add ajx-do-not-delete
type of labelownerReferences
or not having an annotationI'm inclined for 1+2, do not add any label, unless explicitly set in the canary object under
spec.deployment.labels
WDYT?
The text was updated successfully, but these errors were encountered: