Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promoting with no tiller breaks Flagger canarying #3920

Closed
1 of 3 tasks
carlossg opened this issue May 10, 2019 · 1 comment · Fixed by jenkins-x/jenkins-x-versions#259
Closed
1 of 3 tasks

Promoting with no tiller breaks Flagger canarying #3920

carlossg opened this issue May 10, 2019 · 1 comment · Fixed by jenkins-x/jenkins-x-versions#259
Assignees

Comments

@carlossg
Copy link

carlossg commented May 10, 2019

Summary

Flagger creates a parallel deployment jx-app-primary when canary is enabled.

jx-go-demo-6           0/0     0            0           4h55m   go-demo-6    gcr.io/arc-dev-201404/go-demo-6:1.0.20   app=jx-go-demo-6,draft=draft-app   chart=go-demo-6-1.0.20,draft=draft-app,jenkins.io/chart-release=jx,jenkins.io/version=23
jx-go-demo-6-primary   1/1     1            1           49m     go-demo-6    gcr.io/arc-dev-201404/go-demo-6:1.0.20   app=jx-go-demo-6-primary           chart=go-demo-6-1.0.20,draft=draft-app,jenkins.io/chart-release=jx,jenkins.io/version=23

But on promotion it gets deleted when the helm chart is installed because its labels

Removing Kubernetes resources from older releases using selector: jenkins.io/chart-release=jx,jenkins.io/version!=25 from all pvc configmap release sa role rolebinding secret
Removing Kubernetes resources from older releases using selector: jenkins.io/chart-release=jx,jenkins.io/version!=25,jenkins.io/namespace=jx-production from clusterrole clusterrolebinding

Steps to reproduce the behavior

jx promote go-demo-6   --env production     --batch-mode --version 1.0.21

Expected behavior

Actual behavior

Jx version

The output of jx version is:

NAME               VERSION
jx                 2.0.90
jenkins x platform 2.0.191
Kubernetes cluster v1.11.8-gke.6
kubectl            v1.14.0
helm client        Client: v2.12.3+geecf22f
git                git version 2.19.1
Operating System   Mac OS X 10.14.4 build 18E226

Jenkins type

  • Next Generation (Tekton + Prow)
  • Classic Jenkins
  • Serverless Jenkins (JenkinsFileRunner + Prow)

Kubernetes cluster

GKE

Operating system / Environment

@carlossg
Copy link
Author

fixed in flagger 0.13.2 fluxcd/flagger#178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant