Rename spec.canaryAnalysis to spec.analysis #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add analysis field to Canary spec - deprecate canaryAnalysis filed (to be removed in the next API version) - maintain backwards compatibility with v1alpha3 by using spec.canaryAnalysis if spec.analysis is nil - set analysis threshold default value to 1
- rename spec.canaryAnalysis to spec.analysis - required fields: spec.analysis.interval and spec.analysis.threshold
- set Canary API version to flagger.app/v1beta1 - rename canaryAnalysis to analysis
mathetake
approved these changes
Feb 28, 2020
| @@ -1,5 +1,25 @@ | |||
| package controller | |||
|
|
|||
| import ( | |||
| "fmt" | |||
There was a problem hiding this comment.
nit: shoud we execute goimports?
There was a problem hiding this comment.
Indeed, I've added goimports to CI so PRs will fail from now on if imports are not properly formatted.
Thanks for the suggestion
- run gofmt and goimports
stefanprodan
force-pushed
the
analysis-v1beta1
branch
from
ee12d47 to
9a44c5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
analysisfield to Canary APIcanaryAnalysisfiled (to be removed in the next API version)spec.canaryAnalysisifspec.analysisis nilspec.canaryAnalysistospec.analysisspec.analysis.intervalandspec.analysis.thresholdspec.canaryAnalysistospec.analysisUpgrade from v1alpha3 to v1beta1:
apiVersion: flagger.app/v1alpha3withapiVersion: flagger.app/v1beta1spec.canaryAnalysiswithspec.analysisFollowup #457