Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Propagate uppercase proxy env variables to git #2665

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Dec 6, 2019

Only supporting the lowercase ones is confusing for the end users.

@2opremio 2opremio requested a review from squaremo December 6, 2019 15:13
@hiddeco
Copy link
Member

hiddeco commented Dec 9, 2019

There is a reason behind this, the official format of the http_proxy environmental variable is lowercase.

Using the uppercase format has no effect as git follows curl, and curl mentions:

The environment variables can be specified in lower case or upper case. The lower case version has precedence. http_proxy is an exception as it is only available in lower case.

@2opremio
Copy link
Contributor Author

2opremio commented Dec 9, 2019

I did look at the code and didn't see it it handled in lowercase, but I thought I wasn't checking it properly

@2opremio 2opremio mentioned this pull request Dec 9, 2019
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@2opremio 2opremio merged commit e7568b2 into fluxcd:master Dec 10, 2019
@2opremio 2opremio deleted the uppercase-proxy-envs branch December 10, 2019 08:41
@2opremio 2opremio added this to the 1.17.0 milestone Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants