Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Propagate uppercase proxy env variables to git #2665

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Propagate uppercase proxy env variables to git #2665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05ff529
Propagate uppercase proxy env variables to git
2opremio Dec 6, 2019
9e75d60
Remove HTTP_PROXY and add comment about it
Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/git/operations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ var exemptedTraceCommands = []string{

// Env vars that are allowed to be inherited from the OS
var allowedEnvVars = []string{
// these are for people using (no) proxies
"http_proxy", "https_proxy", "no_proxy", "GIT_PROXY_COMMAND",
// these are for people using (no) proxies. Git follows the curl conventions, so HTTP_PROXY
// is intentionally missing
"http_proxy", "https_proxy", "no_proxy", "HTTPS_PROXY", "NO_PROXY", "GIT_PROXY_COMMAND",
// these are needed for GPG to find its files
"HOME", "GNUPGHOME",
// these for the git-secrets helper
Expand Down