Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup based on source and metrics #515

Closed
tanveergill opened this issue Sep 19, 2022 · 3 comments · Fixed by #821
Closed

Rollup based on source and metrics #515

tanveergill opened this issue Sep 19, 2022 · 3 comments · Fixed by #821
Assignees

Comments

@tanveergill
Copy link
Contributor

tanveergill commented Sep 19, 2022

Current implementation

  • Generic rollups for all sources and metric types

Describe the solution you'd like

  1. Rollups based on source: Request and Response length only for Envoy source
  2. Rollups based on type of metric: Create data sketch rollups only in case of Duration type metrics

Additional context

  • Refer how metrics processor is processing based on source of metrics
@krdln
Copy link
Contributor

krdln commented Oct 20, 2022

@tanveergill

Rollups based on source: Request and Response length only for Envoy source

I think this introduces only additional complexity. We should simply skip rollup if field doesn't exist. Which is already the current logic.

@tanveergill
Copy link
Contributor Author

@krdln, got it. Closing

@krdln
Copy link
Contributor

krdln commented Oct 21, 2022

Reopening, as this is still valid point

  1. Rollups based on type of metric: Create data sketch rollups only in case of Duration type metrics

@krdln krdln reopened this Oct 21, 2022
DariaKunoichi added a commit that referenced this issue Oct 26, 2022
DariaKunoichi added a commit that referenced this issue Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants