-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup based on metrics #821
Conversation
Codecov ReportBase: 37.26% // Head: 37.28% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
+ Coverage 37.26% 37.28% +0.02%
==========================================
Files 273 273
Lines 20392 20400 +8
==========================================
+ Hits 7599 7607 +8
Misses 12311 12311
Partials 482 482
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DariaKunoichi)
pkg/otelcollector/rollupprocessor/processor_test.go
line 93 at r1 (raw file):
logRecord = logs.AppendEmpty() logRecord.Attributes().PutStr(otelcollector.WorkloadDurationLabel, strconv.Itoa(attributeValues[2])) logRecord.Attributes().PutStr(otelcollector.ApertureSourceLabel, otelcollector.ApertureSourceEnvoy)
Nit: can you add some https://developers.google.com/protocol-buffers/docs/reference/google.protobuf#google.protobuf.Value
labels and make sure the datasketch is not created? (NotTo(HaveKey(...)
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DariaKunoichi)
pkg/otelcollector/rollupprocessor/processor_test.go
line 93 at r1 (raw file):
Previously, krdln (Michał Krasnoborski) wrote…
Nit: can you add some
https://developers.google.com/protocol-buffers/docs/reference/google.protobuf#google.protobuf.Value
labels and make sure the datasketch is not created? (NotTo(HaveKey(...)
)
I meant HTTPRequestContentLength
(bad copy-paste :P)
Closes: GH-515
Description of change
Checklist
This change is