Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup based on metrics #821

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Rollup based on metrics #821

merged 2 commits into from
Oct 26, 2022

Conversation

DariaKunoichi
Copy link
Contributor

@DariaKunoichi DariaKunoichi commented Oct 26, 2022

Closes: GH-515

Description of change

Checklist
  • Tested in playground or other setup

This change is Reviewable

@DariaKunoichi DariaKunoichi requested a review from a team as a code owner October 26, 2022 13:47
@DariaKunoichi DariaKunoichi changed the title Rollup based on source and metrics Rollup based on metrics Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 37.26% // Head: 37.28% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (5ad17af) compared to base (066bcb0).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 5ad17af differs from pull request most recent head 23d5b57. Consider uploading reports for the commit 23d5b57 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
+ Coverage   37.26%   37.28%   +0.02%     
==========================================
  Files         273      273              
  Lines       20392    20400       +8     
==========================================
+ Hits         7599     7607       +8     
  Misses      12311    12311              
  Partials      482      482              
Impacted Files Coverage Δ
pkg/otelcollector/rollupprocessor/rollup.go 100.00% <ø> (ø)
pkg/otelcollector/rollupprocessor/processor.go 87.15% <100.00%> (+0.48%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@krdln krdln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DariaKunoichi)


pkg/otelcollector/rollupprocessor/processor_test.go line 93 at r1 (raw file):

			logRecord = logs.AppendEmpty()
			logRecord.Attributes().PutStr(otelcollector.WorkloadDurationLabel, strconv.Itoa(attributeValues[2]))
			logRecord.Attributes().PutStr(otelcollector.ApertureSourceLabel, otelcollector.ApertureSourceEnvoy)

Nit: can you add some https://developers.google.com/protocol-buffers/docs/reference/google.protobuf#google.protobuf.Value labels and make sure the datasketch is not created? (NotTo(HaveKey(...))

Copy link
Contributor

@krdln krdln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DariaKunoichi)


pkg/otelcollector/rollupprocessor/processor_test.go line 93 at r1 (raw file):

Previously, krdln (Michał Krasnoborski) wrote…

Nit: can you add some https://developers.google.com/protocol-buffers/docs/reference/google.protobuf#google.protobuf.Value labels and make sure the datasketch is not created? (NotTo(HaveKey(...))

I meant HTTPRequestContentLength (bad copy-paste :P)

@DariaKunoichi DariaKunoichi enabled auto-merge (squash) October 26, 2022 16:42
@DariaKunoichi DariaKunoichi merged commit 6e635fd into main Oct 26, 2022
@DariaKunoichi DariaKunoichi deleted the GH-515 branch October 26, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollup based on source and metrics
2 participants