Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Prometheus metrics and OLAP Flow events #720

Closed
tanveergill opened this issue Oct 7, 2022 · 0 comments · Fixed by #878
Closed

Document Prometheus metrics and OLAP Flow events #720

tanveergill opened this issue Oct 7, 2022 · 0 comments · Fixed by #878
Assignees

Comments

@tanveergill
Copy link
Contributor

What

  • Add a docs section at References/Metrics: A catalog (a table per sub-section) of all metrics in Aperture.
    • Format of metrics table
      • Metric Name: Name of the metric
      • Metric Type: Type of Prometheus metric (Histogram, Summary, Counter etc.)
      • Labels: Default labels available on the metric
      • Unit: ms, %age, byte, count (no unit) etc. See units reference in Prometheus docs
      • Description: Description of the metric
    • Format of labels table (for documenting labels across all sub-sections)
      • Label Name: Name of the label
      • Example Values: List all or few possible examples
      • Description: Description of the metric
    • Sub-sections
      • Aperture System Common
        • Job metrics
        • Go process metrics
        • etc.
      • Agent metrics
        • FluxMeter
        • ConcurrencyLimiter
        • RateLimiter
        • Classifier
        • Dataplane Summary (flowcontrol_requests_total, distcache_entries_total etc.)
      • Controller metrics
        • Signal metrics
    • Source of truth
      • Metric schema file
      • Can jump to references of metric name to find the Prometheus register call which should have the description. See example.
  • Add a docs section at References/Flow Events: Schema (table) of Flow events
    • Format of Dimension Columns table
      • Dimension Name: Name of the dimension
      • Dimension Type: Whether it's a single or multi-value dimension
      • Example Values: List all or few possible examples
      • Description: Description of the dimension
      • Flow Control Integrations: The Flow Control Integrations in which this dimension is available. Example Armeria HTTP, Armeria RPC, Envoy
    • Format of Metric Columns table
      • Metric Name: Name of the metric
      • Metric Type: Integer, Float or Quantile DataSketch
      • Rollup Type: Max, Min, Sum, Quantile DataSketch
      • Unit: ms, %age, byte, count (no unit) etc.
      • Description: Description of the metric
    • Source of truth
@hasit hasit assigned hasit and unassigned seunghyupoh3517 Oct 31, 2022
hasit added a commit that referenced this issue Nov 4, 2022
### Description of change

Closes: #720 

##### Checklist

- [ ] Tested in playground or other setup
- [x] Documentation is changed or added
- [ ] Tests and/or benchmarks are included
- [ ] Breaking changes

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/fluxninja/aperture/878)
<!-- Reviewable:end -->
@hasit hasit closed this as completed in #878 Nov 4, 2022
hdkshingala pushed a commit that referenced this issue Nov 7, 2022
### Description of change

Closes: #720 

##### Checklist

- [ ] Tested in playground or other setup
- [x] Documentation is changed or added
- [ ] Tests and/or benchmarks are included
- [ ] Breaking changes

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/fluxninja/aperture/878)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants