Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Prometheus metrics and OLAP Flow events #878

Merged
merged 11 commits into from
Nov 4, 2022
Merged

Conversation

hasit
Copy link
Contributor

@hasit hasit commented Nov 2, 2022

Description of change

Closes: #720

Checklist
  • Tested in playground or other setup
  • Documentation is changed or added
  • Tests and/or benchmarks are included
  • Breaking changes

This change is Reviewable

@hasit hasit self-assigned this Nov 2, 2022
@hasit hasit requested a review from a team as a code owner November 2, 2022 09:19
@hasit hasit marked this pull request as draft November 2, 2022 09:19
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 37.57% // Head: 37.53% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (862eb1a) compared to base (a642494).
Patch has no changes to coverable lines.

❗ Current head 862eb1a differs from pull request most recent head 85f1a87. Consider uploading reports for the commit 85f1a87 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
- Coverage   37.57%   37.53%   -0.04%     
==========================================
  Files         279      279              
  Lines       20592    20592              
==========================================
- Hits         7737     7729       -8     
- Misses      12378    12384       +6     
- Partials      477      479       +2     
Impacted Files Coverage Δ
pkg/otelcollector/metricsprocessor/processor.go 63.24% <ø> (ø)
pkg/otelcollector/rollupprocessor/processor.go 87.15% <ø> (ø)
...ol/actuators/concurrency/scheduler/token-bucket.go 91.48% <0.00%> (-4.26%) ⬇️
...flowcontrol/actuators/concurrency/scheduler/wfq.go 93.79% <0.00%> (-1.31%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hasit added 2 commits November 4, 2022 08:53
- Add HTTP, GRPC common metrics tables
- Add labels that are added by default in agent and controller metrics tables
@hasit hasit marked this pull request as ready for review November 4, 2022 16:39
@hasit hasit requested a review from a team as a code owner November 4, 2022 16:39
@hasit hasit merged commit 1c76317 into main Nov 4, 2022
@hasit hasit deleted the 720-document-metrics branch November 4, 2022 19:58
hdkshingala pushed a commit that referenced this pull request Nov 7, 2022
### Description of change

Closes: #720 

##### Checklist

- [ ] Tested in playground or other setup
- [x] Documentation is changed or added
- [ ] Tests and/or benchmarks are included
- [ ] Breaking changes

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/fluxninja/aperture/878)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Prometheus metrics and OLAP Flow events
3 participants