-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response status in telemetry #828
Conversation
Codecov ReportBase: 37.17% // Head: 37.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #828 +/- ##
==========================================
+ Coverage 37.17% 37.46% +0.29%
==========================================
Files 273 278 +5
Lines 20470 20489 +19
==========================================
+ Hits 7610 7677 +67
+ Misses 12374 12332 -42
+ Partials 486 480 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
92889fa
to
4a06a52
Compare
### Description of change This fixes regression introduced in #828. Dynamic Telemetry Flow Labels were added before labels filtering, which led them to be incorrectly filtered out. ##### Checklist - [x] Tested in playground or other setup - [x] Breaking changes
### Description of change This fixes regression introduced in #828. Dynamic Telemetry Flow Labels were added before labels filtering, which led them to be incorrectly filtered out. ##### Checklist - [x] Tested in playground or other setup - [x] Breaking changes
Description of change
This introduces
aperture.response_status
column in telemetry. It mirrors the implementation ofresponse_status
label for metrics.This also extends above logic to include
1xx
,2xx
, and3xx
codes as OK instead of only2xx
codes.Besides this, some cleanup is done:
FluxMeter
to OTEL package. This changes FluxMeter interface!metricsprocessor
tometricsprocessor/internal
for better visibility and easier separation of functions which are called directly in metricsprocessor and helpers,Ref: https://github.com/fluxninja/cloud/issues/6788
Checklist
This change is