Fix telemetry labels propagation #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 37.46% // Head: 37.47% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
=======================================
Coverage 37.46% 37.47%
=======================================
Files 278 278
Lines 20488 20490 +2
=======================================
+ Hits 7676 7678 +2
Misses 12332 12332
Partials 480 480
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kwapik
force-pushed
the
kwapik/fix_telemetry_labels_propagation
branch
from
8f7e41d to
d4ca2d1
Compare
kklimonda-fn
pushed a commit
that referenced
this pull request
Oct 28, 2022
### Description of change This fixes regression introduced in #828. Dynamic Telemetry Flow Labels were added before labels filtering, which led them to be incorrectly filtered out. ##### Checklist - [x] Tested in playground or other setup - [x] Breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This fixes regression introduced in #828.
Dynamic Telemetry Flow Labels were added before labels filtering, which led them to be incorrectly filtered out.
Checklist
This change is