Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: schema validator for struct type execution #186

Merged
merged 3 commits into from
Aug 24, 2021

Conversation

Pianist038801
Copy link
Contributor

Signed-off-by: Pianist038801 [email protected]

This PR gives ability to enter valid json instead of arbitrary json when working with Generic Structs data in launch forms.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Tracking Issue

fixes flyteorg/flyte#1216

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@d026108). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #186   +/-   ##
=========================================
  Coverage          ?   66.65%           
=========================================
  Files             ?      348           
  Lines             ?     7263           
  Branches          ?     1233           
=========================================
  Hits              ?     4841           
  Misses            ?     2422           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d026108...af41ee5. Read the comment docs.

@Pianist038801 Pianist038801 force-pushed the generic-json-schema-validation branch from 9530880 to 38576cf Compare August 23, 2021 16:54
Signed-off-by: Pianist038801 <[email protected]>
@Pianist038801 Pianist038801 force-pushed the generic-json-schema-validation branch from 38576cf to 2d6eb33 Compare August 24, 2021 01:44
Signed-off-by: Pianist038801 <[email protected]>
Copy link
Contributor

@jsonporter jsonporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@anrusina anrusina deleted the generic-json-schema-validation branch January 13, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI Feature] Generic JSON schema validation in Flyteconsole launch forms
3 participants