Add correct mime type to headers #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonporter
force-pushed
the
add-mime-type-to-prod-headers
branch
from
8dd9c90 to
f8ff141
Compare
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
=========================================
Coverage ? 63.44%
=========================================
Files ? 365
Lines ? 7909
Branches ? 1385
=========================================
Hits ? 5018
Misses ? 2891
Partials ? 0 Continue to review full report at Codecov.
|
jsonporter
force-pushed
the
add-mime-type-to-prod-headers
branch
from
f8ff141 to
53a182c
Compare
Signed-off-by: Jason Porter <[email protected]>
jsonporter
force-pushed
the
add-mime-type-to-prod-headers
branch
from
53a182c to
06b8785
Compare
|
🎉 This PR is included in version 0.31.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit appends to #235 but moves the
webpack-plugin-servemiddleware to apply to both prod and dev builds.Type
Are all requirements met?
Complete description
Serve middleware sets the MIME type of main-[hash].js to `application/javascrtipt'. This middleware was initially configured to apply to dev-only; this change applies it to both prod and dev builds.
Tracking Issue
Follow-up issue
#235