Sync with Prism Launcher 8.0, rework custom account implementation #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: TheKodeToad <[email protected]>
Signed-off-by: TheKodeToad <[email protected]>
into develop Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
See https://zimbatm.com/notes/1000-instances-of-nixpkgs Signed-off-by: Sefa Eyeoglu <[email protected]>
Signed-off-by: TheKodeToad <[email protected]>
Signed-off-by: TheKodeToad <[email protected]>
Signed-off-by: TheKodeToad <[email protected]>
Signed-off-by: TheKodeToad <[email protected]>
this flag is unavailable on gcc versions < 8. we could detect the version of the compiler here, but i don't think we lose much in this flags removal and this is a simpler option Signed-off-by: seth <[email protected]>
See NixOS/nixpkgs#252425 Signed-off-by: Sefa Eyeoglu <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Co-authored-by: seth <[email protected]> Signed-off-by: Alexandru Ionut Tripon <[email protected]>
Signed-off-by: Trial97 <[email protected]>
[Linux] Fix loading MangoHud
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Updated the readme
Fix crash with mod icon caching
Localize sorting options for resource and shader packs
Added Global Dependenicies toggle
fixed squished mod icons
|
Ah, Prism Launcher 8.0 is out now, so a backport will not be necessary: https://github.com/PrismLauncher/PrismLauncher/releases/tag/8.0 |
|
This resolves #66. |
Signed-off-by: Evan Goode <[email protected]>
Fixes a bug where the wrong account could be marked as "in use" when the game is launched if there are multiple accounts that share the same profile ID. This can lead to the launcher trying to refresh an account that's currently in use by the game, leading to "Invalid session" errors in-game. Signed-off-by: Evan Goode <[email protected]>
Merge develop -> unmojang, link to wiki page with common authlib-injector servers
Upstream changelog: https://github.com/PrismLauncher/PrismLauncher/releases/tag/8.0 (Imcomplete) list of changes in 8.0 relevant to PollyMC: - Prism has dropped support for Mojang accounts - PrismLauncher/PrismLauncher#1656 - Added it back to PollyMC primarily since the Mojang authentication code is also used for authlib-injector accounts. Some users may also still want to be able to log in to Mojang accounts for some reason: fn2006#115 (comment), even if they do not provide authentication to multiplayer servers. - To my surprise, I could still log in to a Mojang account, get its skin, and launch the game. Authentication to servers, of course, did not work. - Tested: logging into authlib-injector, Mojang, and MSA accounts and launching the game. - Prism has added a built-in updater for Windows and Linux that I assume provides similar functionality to Sparkle on macOS: PrismLauncher/PrismLauncher#1268. There is a Launcher_UPDATER_GITHUB_REPO variable in CMakeLists.txt that specifies the repo checked by the updater. I have changed this to the PollyMC repository, and since PollyMC follows almost the same CI/release patterns as Prism Launcher, it might work with PollyMC, too, but I have not tested it yet. - Add macOS support to Nix - PrismLauncher/PrismLauncher#1485 - Untested - The "PollyMC-Linux-8.0.tar.gz" and similar build artifacts were renamed to "PollyMC-Linux-8.0-Qt5.tar.gz" to match their "PollyMC-Linux-8.0-Qt6.tar.gz" counterparts. - Removed Windows MSVC Legacy builds - Removed Quilt Beacon toggle, the beacon is now always disabled: PrismLauncher/PrismLauncher#1547, PrismLauncher/meta#23 - Prism removed FTB support in 7.0, but I tested creating an FTB instance to make sure it still works in 8.0 Signed-off-by: Evan Goode <[email protected]>
Signed-off-by: Evan Goode <[email protected]>
Smooth Ely.by -> authlib-injector migration
Original authlib-injector work had a bug making offline accounts not save correctly.
Signed-off-by: Evan Goode <[email protected]>
Merge PrismLauncher:8.0 to unmojang
evan-goode
changed the title
|
This PR now includes the changes from Prism Launcher 8.0 and thus also resolves #115. |
fn2006
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rewrite of the custom account implementation to add support for API servers other than Ely.by and to allow using a specific version of authlib-injector on each instance.
Blocked by #111.
I'm not sure when Prism Launcher 8.0 will be released, so if this is merged, we'll likely want to backport the changes to the 7.2 branch and create a release from that branch.