Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove server constants #391

Closed
Temikus opened this issue Jul 14, 2018 · 1 comment · Fixed by #500
Closed

Remove server constants #391

Temikus opened this issue Jul 14, 2018 · 1 comment · Fixed by #500
Labels
bug priority/medium
Milestone
2.0

Comments

@Temikus
Copy link
Member

Temikus commented Jul 14, 2018 

      # TODO: Do we need those constants?
      RUNNING = "RUNNING".freeze
      PROVISIONING = "PROVISIONING".freeze
      STAGING = "STAGING".freeze
@Temikus Temikus added this to the 2.0 milestone Jul 14, 2018
@Temikus
Copy link
Member Author

Temikus commented Jul 14, 2018

Yeah, we can get rid of those, they no longer serve purpose it seems.
We (more "I" here to be honest) just have been cargo-culting those changes for a while.

It used to be relevant("RUNNING_STATE"), but no longer is.
See: fog/fog@7814ae5

@Temikus Temikus changed the title Rethink server constants Remove server constants Jul 16, 2018
@Temikus Temikus added the bug label Jul 16, 2018
Temikus added a commit to Temikus/fog-google that referenced this issue Jul 22, 2020
@Temikus
Remove unneeded constants
82f4029 
It used to be relevant("RUNNING_STATE"), but no longer is.
See: fog/fog@7814ae5

Fixes fog#391
@Temikus Temikus mentioned this issue Jul 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority/medium
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Remove unneeded constants Temikus/fog-google
1 participant
@Temikus