Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded constants #500

Merged
merged 4 commits into from
Jul 22, 2020
Merged

Conversation

Temikus
Copy link
Member

@Temikus Temikus commented Jul 22, 2020

It used to be relevant("RUNNING_STATE"), but no longer is.
See: fog/fog@7814ae5

Fixes #391

It used to be relevant("RUNNING_STATE"), but no longer is.
See: fog/fog@7814ae5

Fixes fog#391
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #500 into master will increase coverage by 1.79%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   85.70%   87.50%   +1.79%     
==========================================
  Files         341      341              
  Lines        5737     5736       -1     
==========================================
+ Hits         4917     5019     +102     
+ Misses        820      717     -103     
Impacted Files Coverage Δ
lib/fog/compute/google.rb 100.00% <ø> (ø)
...fog/compute/google/requests/set_server_metadata.rb 100.00% <ø> (ø)
lib/fog/compute/google/models/server.rb 79.52% <33.33%> (+1.42%) ⬆️
...ib/fog/google/requests/pubsub/pull_subscription.rb 91.66% <100.00%> (+1.66%) ⬆️
...g/compute/google/models/instance_group_managers.rb 30.43% <0.00%> (-69.57%) ⬇️
lib/fog/compute/google/models/instance_groups.rb 29.03% <0.00%> (-51.62%) ⬇️
lib/fog/compute/google/models/instance_template.rb 50.00% <0.00%> (-50.00%) ⬇️
...ib/fog/compute/google/models/instance_templates.rb 50.00% <0.00%> (-50.00%) ⬇️
...g/compute/google/requests/insert_instance_group.rb 57.14% <0.00%> (-35.72%) ⬇️
...og/compute/google/models/instance_group_manager.rb 64.70% <0.00%> (-26.48%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63826d0...bb6707c. Read the comment docs.

@Temikus
Copy link
Member Author

Temikus commented Jul 22, 2020

Hm, something happened to our testing bucket gs://fog-test-bucket, investigating...

Temikus added 2 commits July 22, 2020 14:49
Looks like the old one was in a project that was staged for deletion.
Since `reverse_merge` is only a rails thing, we're doing it manually here.
@Temikus Temikus force-pushed the remove_unneeded_constants branch from 96deda4 to 3857eb9 Compare July 22, 2020 08:33
Seems like PubSub latency sometimes exceeds the time between us creating a topic/sub and pulling it so we're setting the option on the request to wait.
@Temikus Temikus force-pushed the remove_unneeded_constants branch from 3857eb9 to bb6707c Compare July 22, 2020 09:27
@Temikus Temikus merged commit 58a9858 into fog:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove server constants
1 participant