Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade google-api-client, fix broken tests #469

Merged
merged 5 commits into from
Oct 5, 2019
Merged

Upgrade google-api-client, fix broken tests #469

merged 5 commits into from
Oct 5, 2019

Conversation

icco
Copy link
Member

@icco icco commented Sep 21, 2019 •
edited
Loading

This takes #468 and tries to fix the failing tests as well.

@icco icco added the integrate label Sep 21, 2019
@codecov
Copy link

codecov bot commented Sep 21, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@6547d5a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #469   +/-   ##
=========================================
  Coverage          ?   88.86%           
=========================================
  Files             ?      339           
  Lines             ?     5633           
  Branches          ?        0           
=========================================
  Hits              ?     5006           
  Misses            ?      627           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6547d5a...98663b2. Read the comment docs.

@icco icco changed the title Fix zone tests Upgrade google-api-client, fix broken tests Sep 21, 2019
@Temikus
Copy link
Member

Temikus commented Sep 21, 2019

Please do not merge yet as this is actually worrying as empty get should return all zones. Is this only failing with the new lib version?

@Temikus
Copy link
Member

Temikus commented Sep 21, 2019

Ah sorry nvm read the diff wrong m(_ _)m

@icco
Copy link
Member Author

icco commented Sep 21, 2019

So it's failing with some subset of zones, which is concerning. Also some stackdriver tests are failing, which I haven't been able to figure out yet.

@icco
Copy link
Member Author

icco commented Sep 21, 2019

Hmm, just seems to be flaky. Added some debugging, and the tests stopped failing... whee.

@icco icco requested a review from Temikus September 21, 2019 18:20
Temikus
Temikus approved these changes Sep 22, 2019
View reviewed changes
Copy link
Member

@Temikus Temikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM.

test/integration/monitoring/test_timeseries.rb Outdated Show resolved Hide resolved
@icco icco merged commit 3ae91ed into master Oct 5, 2019
@icco icco deleted the fix_zone_tests branch October 5, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Temikus Temikus Temikus approved these changes

Assignees

@icco icco

Labels
integrate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icco @Temikus