Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade google-api-client, fix broken tests #469

Merged
merged 5 commits into from
Oct 5, 2019
Merged

Upgrade google-api-client, fix broken tests #469

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
093c118
Update google-api-client requirement from >= 0.23, < 0.31 to >= 0.23,…
dependabot-preview[bot] Sep 16, 2019
85dd36b
Print zone when testing
icco Sep 21, 2019
cdf3691
Add extra logging to metric test
icco Sep 21, 2019
737dd12
Fix style on assertion
icco Sep 21, 2019
98663b2
Remove debug statement
icco Oct 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fog-google.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
spec.add_dependency "fog-xml", "~> 0.1.0"

# Hard Requirement as of 1.0
spec.add_dependency "google-api-client", ">= 0.23", "< 0.31"
spec.add_dependency "google-api-client", ">= 0.23", "< 0.32"

# Debugger
spec.add_development_dependency "pry"
Expand Down
2 changes: 1 addition & 1 deletion test/integration/compute/core_compute/test_zones.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def test_get
# This tests only in last zone since not all zones contain all machine types
ZONES.each do |name|
zone = @subject.get(name)
refute_nil(zone, "zones.get() should not return nil")
refute_nil(zone, "zones.get(#{name}) should not return nil")
assert(zone.up?, "zones.up? should return up, unless there's an outage")
end
end
Expand Down
5 changes: 4 additions & 1 deletion test/integration/monitoring/test_timeseries.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,9 @@ def test_multiple_timeseries
:page_size => 1
)
end

mu_pp_for_diff(resp)
icco marked this conversation as resolved.
Show resolved Hide resolved
refute_nil(resp.time_series, "expected timeseries to not be nil")
assert_equal(resp.time_series.size, 1,
"expected timeseries count to be equal to page size 1")

Expand All @@ -164,7 +167,7 @@ def test_multiple_timeseries
"expected timeseries count to be equal to page size 1")
labels = resp.time_series.first.metric.labels
labels_next = next_resp.time_series.first.metric.labels
assert(labels != labels_next,
refute_equal(labels, labels_next,
"expected different timeseries when using page_token")

# Test filter
Expand Down