Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for credentials file #42

Merged
merged 1 commit into from
May 31, 2022

Conversation

thatnerdjosh
Copy link
Contributor

@thatnerdjosh thatnerdjosh commented May 31, 2022

This PR:

  1. Allows for user to configure either a credentials.json file, or continue to use an API key
  2. Translates usage of deprecated transport.APIKey to option.WithAPIKey

@thatnerdjosh thatnerdjosh force-pushed the add_credentials_support branch from c664f50 to 1f1560a Compare May 31, 2022 01:15
Copy link
Contributor

@smartinov smartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smartinov smartinov merged commit 68e2ac0 into foomo:master May 31, 2022
@smartinov
Copy link
Contributor

Thanks for the pr @thatnerdjosh !

@thatnerdjosh
Copy link
Contributor Author

@smartinov - would you be able to update the docker image to provide the newest release as a tag?

Thanks!

@smartinov
Copy link
Contributor

@thatnerdjosh On my way!!

@smartinov
Copy link
Contributor

@thatnerdjosh published! Seems that docker registry disabled automatic publishes, had to migrate to github actions!

@thatnerdjosh
Copy link
Contributor Author

@smartinov - would you be able to build it specifically for the 2.1.5 version? There is some bug after that release that I am looking into that affects credential file auth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants