Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames only a few letters of the closing tag.. #62

Open
krearthur opened this issue Jun 18, 2018 · 8 comments
Open

Renames only a few letters of the closing tag.. #62

krearthur opened this issue Jun 18, 2018 · 8 comments

Comments

@krearthur
Copy link

MacOS: 10.13.5
VSCode: 1.24.1
Auto-rename-tag version: 0.0.15

After updating VSCode, the extensions and also my mac, I get a weird behaviour when renaming my tags in my xml files.
When I rename a tag, the corresponding closing tag sometimes will be renamed too but without all letters I typed.
for example:
I have the tag <myProduct>, and I deleted the Product part, the closing tag resulted in </myPr>, and so when I started to rename to <myAttribute>, the closing tag didn't change.

sorry for the bad explanation..

note that I have also installed the auto close tag extension

@Astrantia
Copy link

Astrantia commented Jun 22, 2018

This happens to me all the time too @formulahendry

@agrakhov
Copy link

same issue with JSX files
VS code 1.23.1
Plugin: 0.0.15

@iamdevlinph
Copy link

The issue happens if you type fast. The known work around is to type slowly which is kind of inconvenient.

Tested use case on both .html and .jsx

auto rename tag

@pascal-kubrick
Copy link

Happens to me too, @iamdevlinph seems to be right. I can replicate it consistently by typing too fast.

@JosNun
Copy link

JosNun commented Aug 28, 2018

Is a fix planned?

@Morgy93
Copy link

Morgy93 commented Nov 21, 2018

Same issue here, will try the slow typing thing next time.

silently pushes this issue

@tdd
Copy link

tdd commented Jan 25, 2019

Most of the "typing fast breaks stuff" should be fixable using a debounced handler for text selection change events. I'll need to look into it anyway, as I'm about to fork this to try and fix a number of issues.

@mtjn
Copy link

mtjn commented Feb 12, 2019

Also experiencing this issue using v0.0.15

Version: 1.31.0 (user setup)
Commit: 7c66f58312b48ed8ca4e387ebd9ffe9605332caa
Date: 2019-02-05T22:35:56.624Z
Electron: 3.1.2
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants