Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Display unavailability of network connection during event update #1487

Merged
merged 6 commits into from
Feb 1, 2019
Merged

fix: Display unavailability of network connection during event update #1487

merged 6 commits into from
Feb 1, 2019

Conversation

ShridharGoel
Copy link
Member

@ShridharGoel ShridharGoel commented Jan 31, 2019 •
edited
Loading

Fixes #1486

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes:

Now, "Network Not Available" message would be displayed when the user tries to edit event but internet connection is not available.

GIF for the change:

ezgif com-video-to-gif 29

Masquerade0097
Masquerade0097 reviewed Jan 31, 2019
View reviewed changes
Copy link
Member

@Masquerade0097 Masquerade0097 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach a gif for the change.

@codecov
Copy link

codecov bot commented Jan 31, 2019 •
edited
Loading

Codecov Report

Merging #1487 into development will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1487      +/-   ##
=================================================
- Coverage          24.08%   24.07%   -0.01%     
  Complexity           757      757              
=================================================
  Files                237      237              
  Lines               8799     8802       +3     
  Branches             360      360              
=================================================
  Hits                2119     2119              
- Misses              6596     6599       +3     
  Partials              84       84
Impacted Files Coverage Δ Complexity Δ
...anizer/core/event/create/CreateEventViewModel.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ganizer/core/event/create/UpdateEventFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...nizer/core/event/create/EventDetailsStepThree.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f4231...ca0b401. Read the comment docs.

@ShridharGoel
Copy link
Member Author

@Masquerade0097 Done.

Masquerade0097
Masquerade0097 approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@Masquerade0097 Masquerade0097 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamareebjamal iamareebjamal merged commit 4e737fd into fossasia:development Feb 1, 2019
@ShridharGoel ShridharGoel mentioned this pull request Mar 20, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Masquerade0097 Masquerade0097 Masquerade0097 approved these changes

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShridharGoel @iamareebjamal @Masquerade0097