-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent false error while creating events #1567
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1567 +/- ##
==============================================
Coverage 24.83% 24.83%
Complexity 800 800
==============================================
Files 238 238
Lines 8952 8952
Branches 368 368
==============================================
Hits 2223 2223
Misses 6645 6645
Partials 84 84
Continue to review full report at Codecov.
|
But what about the error messages which were mentioned here? |
@kush-mish Everything is working fine except the case when internet connection isn't available. This PR can be considered as a temporary fix for the problem of not being able to create events. |
I don't understand why these changes will affect the errors? |
I am also not sure about the strange behaviour. I think it's because the logic for handling the functioning of the next button (clicking which calls the verify function) is in the activity while we were passing the context of the fragments in the ViewModelProviders. |
That's understandable. But why change single event livedata? |
Because using SingleEventLiveData would give |
I had changed it to SingleEventLiveData in #1487 but it has created this issue. |
Fixes #1514
Checklist:
Changes:
Passed the context of the activity instead of the EventDetailsStepThree and UpdateEventFragment fragments in ViewModelProviders to prevent the 'Event name cannot be empty' error message.
Because of this, SingleEventLiveData had to be changed to MutableLiveData.