Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an actor method rollConcentration, with associated dnd5e.preRollConcentration and dnd5e.rollConcentration hooks #3033

Closed
krbz999 opened this issue Feb 12, 2024 · 2 comments
Closed

Provide an actor method rollConcentration, with associated dnd5e.preRollConcentration and dnd5e.rollConcentration hooks #3033

krbz999 opened this issue Feb 12, 2024 · 2 comments
Assignees
@krbz999
Labels
api
Milestone
D&D5E 3.1.0

Comments

@krbz999
Copy link
Contributor

krbz999 commented Feb 12, 2024

Related to #3028.
@arbron arbron added the api label Feb 12, 2024
@arbron arbron added this to the D&D5E 3.1.0 milestone Feb 12, 2024
krbz999 added a commit to krbz999/dnd5e that referenced this issue Feb 21, 2024
@krbz999
[foundryvtt#3033] Add actor method and hooks
f8095c9
@kaelad02
Copy link
Contributor

Please make sure the dnd5e.preRollConcentration hook is called before the roll dialog is shown. This wasn't done with initiative and... well made things difficult for modules to really change things.

@krbz999
Copy link
Contributor Author

krbz999 commented Feb 26, 2024

Please make sure the dnd5e.preRollConcentration hook is called before the roll dialog is shown. This wasn't done with initiative and... well made things difficult for modules to really change things.

I swear it on my life.

krbz999 added a commit to krbz999/dnd5e that referenced this issue Mar 5, 2024
@krbz999
[foundryvtt#3033] Add actor method and hooks
950eb9e
krbz999 added a commit to krbz999/dnd5e that referenced this issue Mar 5, 2024
@krbz999
[foundryvtt#3033]
bac6d00
Fyorl pushed a commit that referenced this issue Mar 5, 2024
@krbz999
[#3033] Add concentration actor method and hooks (#3097)
9256726 
Co-authored-by: Zhell <[email protected]>
@Fyorl Fyorl closed this as completed Mar 5, 2024
@kgar kgar mentioned this issue Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krbz999 krbz999

Labels
api
Projects
None yet
Milestone
D&D5E 3.1.0
Development

No branches or pull requests
4 participants
@Fyorl @kaelad02 @arbron @krbz999