Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (dnd5e 3.1.x) Implement Concentration UI #515

Closed
kgar opened this issue Mar 22, 2024 · 2 comments
Closed

feat: (dnd5e 3.1.x) Implement Concentration UI #515

kgar opened this issue Mar 22, 2024 · 2 comments
Assignees
@kgar
Labels
dnd5e This relates to dnd5e system updates or issues enhancement New feature or request
Milestone
3.1.x Feature Rol...

Comments

@kgar
Copy link
Owner

kgar commented Mar 22, 2024 •
edited
Loading

The character sheet now features a Concentration roll button while the character is concentrating:
image

Likewise, there is a context menu option to break concentration:

image

Note

Concentration Effect doesn't have an option to disable.

Currently, this is only featured on the Default 5e Character sheet. If possible, include it for any actor type that is capable of concentrating.
@kgar kgar added the dnd5e This relates to dnd5e system updates or issues label Mar 22, 2024
@kgar kgar added this to the 3.1.x Feature Rollout milestone Mar 22, 2024
@kgar kgar added the enhancement New feature or request label Mar 22, 2024
@kgar kgar changed the title feat: (dnd5e 3.1.x) Implement Concentration Roll Button UI feat: (dnd5e 3.1.x) Implement Concentration UI Mar 22, 2024
@kgar
Copy link
Owner Author

kgar commented Mar 22, 2024 •
edited
Loading

3033 Added an actor method (rollConcentration), with associated dnd5e.preRollConcentration and dnd5e.rollConcentration hooks.
💵

@kgar kgar self-assigned this Mar 26, 2024
@kgar kgar mentioned this issue Mar 26, 2024
Merged
kgar added a commit that referenced this issue Mar 26, 2024
@kgar
[#515] Tidy Concentration UI (#530)
c138734 
* Added "Break Concentration" option for the concentration effect. Prevented "Disable" option from appearing, since "Break Concentration" is the logical replacement for it.

Added CSS support for context menu grouping and dnd5e-icon elements.

Added concentration state to the Character and NPC sheet properties.

Fixed missing NPC effects context menu for effects that do not have a `parentId` property (legacy transfer effects, perhaps?).

* Added special EffectToggleControl component for dealing with active effect enable/disable. Because concentration is a special replacement of the Disable control, it represents a third state in that particular slot on the classic controls menu.

Added support for Dnd5eIcon in ItemControl, by way of an iconSrc string prop.

Extracted concentration effect detection to a FoundryAdapter function.

Added common context field for special saves / concentration.

Made proficiency and movement configs show/hide when the sheet is unlocked/locked.

Added SpecialSaves component and put it to the right of the ActorMovement component in NPC and Character sheet headers.

* Fixed middle-click error for character effects.
Fixed drag data error for character effects.
Fixed error when deleting a character effect.

* Renamed toggle control so that it specifies that it's made specifically for actors.
@kgar kgar added the awaiting-release This is awaiting release label Mar 26, 2024
@kgar
Copy link
Owner Author

kgar commented Mar 27, 2024

Closing as completed.

@kgar kgar closed this as completed Mar 27, 2024
@kgar kgar removed the awaiting-release This is awaiting release label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgar kgar

Labels
dnd5e This relates to dnd5e system updates or issues enhancement New feature or request
Projects
None yet
Milestone
3.1.x Feature Rollout
Development

No branches or pull requests
1 participant
@kgar