Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically select spellcasting ability based on class set on spell #3763

Closed
arbron opened this issue Jun 27, 2024 · 0 comments · Fixed by #3764
Closed

Automatically select spellcasting ability based on class set on spell #3763

arbron opened this issue Jun 27, 2024 · 0 comments · Fixed by #3764
Assignees
@arbron
Labels
feature request
Milestone
D&D5E 3.3.0

Comments

@arbron
Copy link
Collaborator

arbron commented Jun 27, 2024

With the merging of #3431 you can now assign a spell to a specific class. For any spells that have a class specified and "Spellcasting" set as their ability, it should automatically use the ability on their assigned class rather than the character-wide spellcasting ability.

The spellcasting ability should still be supported to support older spells without the class field set and to support spellcasting on NPCs which probably don't have a spellcasting class.
@arbron arbron added this to the D&D5E 3.3.0 milestone Jun 27, 2024
@arbron arbron self-assigned this Jun 27, 2024
arbron added a commit that referenced this issue Jun 27, 2024
@arbron
[#3763] Select spellcasting ability based on spell's associated class
d2de752 
Modifies `_typeAbilityMod` property on `SpellData` to first check
the associated spellcasting class if specified on the spell before
falling back to the global spellcasting ability.

Also made a change to `Item5e#getSaveDC` to first ask the item for
its ability to use for the DC before falling back to the global
spell DC.
arbron added a commit that referenced this issue Jun 27, 2024
@arbron
[#3763] Fix potential issue with spells on module actor types
d30f48b
@arbron arbron mentioned this issue Jun 28, 2024
Merged
arbron added a commit that referenced this issue Jul 18, 2024
@arbron
[#3763] Cache spellcasting classes on actors
5b6db7c
arbron added a commit that referenced this issue Jul 18, 2024
@arbron
[#3763] Switch from private fields to prevent actor delta bug
14e3211
arbron added a commit that referenced this issue Jul 18, 2024
@arbron
Merge pull request #3764 from foundryvtt/spell-class-ability
3b7089d 
[#3763] Select spellcasting ability based on spell's associated class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbron arbron

Labels
feature request
Projects
None yet
Milestone
D&D5E 3.3.0
Development

Successfully merging a pull request may close this issue.

[#3763] Select spellcasting ability based on spell's associated class foundryvtt/dnd5e
1 participant
@arbron