[#3763] Select spellcasting ability based on spell's associated class #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies `_typeAbilityMod` property on `SpellData` to first check the associated spellcasting class if specified on the spell before falling back to the global spellcasting ability. Also made a change to `Item5e#getSaveDC` to first ask the item for its ability to use for the DC before falling back to the global spell DC.
krbz999
reviewed
Jun 27, 2024
Fyorl
requested changes
Jul 18, 2024
Fyorl
requested changes
Jul 18, 2024
Fyorl
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies
_typeAbilityModproperty onSpellDatato first check the associated spellcasting class if specified on the spell before falling back to the global spellcasting ability.Also made a change to
Item5e#getSaveDCto first ask the item for its ability to use for the DC before falling back to the global spell DC.Closes #3763