Fix parameter name in FrankaHWSim documentation #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xEnVrE can you please resolve conflicts? |
@andrejpan no problem, I'll do it today |
xEnVrE
force-pushed
the
fix/franka_hw_sim_parameter
branch
from
ff6ec87 to
0a96eb1
Compare
|
Done! cc @andrejpan |
|
@andrejpan any news on this? |
|
We need to further investigate this. I think we should rewrite this section since it does not make much sense like this. Tnx for the initiative! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the code here the
FrankaHWSimplugin will search for the parameter<arm_id>/F_T_NEinstead of<arm_id>/NE_T_EEin order to determine the trasnformation from the flange to the nominal end effector.