-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(templates): remove stitcher from CourtListener #4905
base: main
Are you sure you want to change the base?
Conversation
@@ -65,7 +65,7 @@ def inject_settings(request): | |||
% reverse("advanced_oa"), | |||
'CourtListener has an <a href="%s">API</a> so anybody can easily use our data.' | |||
% reverse("api_index"), | |||
'Oral argument podcasts <a href="%s">are available in variety of apps</a> like iTunes, Stitcher Radio, and Google Music.' | |||
'Oral argument podcasts <a href="%s">are available in variety of apps</a> like iTunes, Pocket Casts, and Google Music.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced it with a different one instead of just removing it because it looked better when it was three things being listed instead of just "iTunes and Google Music" but I can also remove it if we don't want to add Pocket Casts for some reason 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know, I hate to say it, but now that you've drawn my attention here, I'm realizing that Google Music doesn't exist anymore either! Maybe we should just say something like, "available wherever you get your podcasts" — that'd be future-proof too, and we can just remove all the logos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense! The only thing is that I personally think the logos make it look a bit nicer and more inviting, so I'd consider how this will look like after the redesign. If this code isn't going to be used anymore, then we might as well keep them for now 🤷 except for Google Music of course!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, if you want. I think after the redesign it'll just be a narrow help page, like the others, so it might not be so bad without them, but sure, either way. :)
@@ -65,7 +65,7 @@ def inject_settings(request): | |||
% reverse("advanced_oa"), | |||
'CourtListener has an <a href="%s">API</a> so anybody can easily use our data.' | |||
% reverse("api_index"), | |||
'Oral argument podcasts <a href="%s">are available in variety of apps</a> like iTunes, Stitcher Radio, and Google Music.' | |||
'Oral argument podcasts <a href="%s">are available in variety of apps</a> like iTunes, Pocket Casts, and Google Music.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know, I hate to say it, but now that you've drawn my attention here, I'm realizing that Google Music doesn't exist anymore either! Maybe we should just say something like, "available wherever you get your podcasts" — that'd be future-proof too, and we can just remove all the logos?
Closes #2948
Also improved responsiveness of app logos:
Before PR
Desktop
iPad/tablet
Phone
After PR
Desktop
iPad/tablet
Phone