Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates): remove stitcher from CourtListener #4905

Merged
merged 8 commits into from
Jan 15, 2025
Merged

fix(templates): remove stitcher from CourtListener #4905

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d16a214
fix(templates): remove stitcher references
elisa-a-v Jan 9, 2025
ccc9a8e
feat(podcasts): improve app logos responsiveness
elisa-a-v Jan 10, 2025
b9fba29
Merge branch 'main' into 2948-remove-stitcher
elisa-a-v Jan 13, 2025
2a957bb
fix(podcasts): remove references to external podcast apps
elisa-a-v Jan 13, 2025
641bf1b
Merge branch 'main' into 2948-remove-stitcher
elisa-a-v Jan 13, 2025
d5e31cb
refactor(audio): remove unused static files for podcast app logos
elisa-a-v Jan 14, 2025
1c99c57
Merge branch 'main' into 2948-remove-stitcher
elisa-a-v Jan 14, 2025
74df6c5
Merge branch 'main' into 2948-remove-stitcher
mlissner Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cl/lib/context_processors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def inject_settings(request):
% reverse("advanced_oa"),
'CourtListener has an <a href="%s">API</a> so anybody can easily use our data.'
% reverse("api_index"),
'Oral argument podcasts <a href="%s">are available in variety of apps</a> like iTunes, Stitcher Radio, and Google Music.'
'Oral argument podcasts <a href="%s">are available in variety of apps</a> like iTunes, Pocket Casts, and Google Music.'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced it with a different one instead of just removing it because it looked better when it was three things being listed instead of just "iTunes and Google Music" but I can also remove it if we don't want to add Pocket Casts for some reason 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, I hate to say it, but now that you've drawn my attention here, I'm realizing that Google Music doesn't exist anymore either! Maybe we should just say something like, "available wherever you get your podcasts" — that'd be future-proof too, and we can just remove all the logos?

Copy link
Contributor Author

@elisa-a-v elisa-a-v Jan 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense! The only thing is that I personally think the logos make it look a bit nicer and more inviting, so I'd consider how this will look like after the redesign. If this code isn't going to be used anymore, then we might as well keep them for now 🤷 except for Google Music of course!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, if you want. I think after the redesign it'll just be a narrow help page, like the others, so it might not be so bad without them, but sure, either way. :)

% reverse("podcasts"),
"We have more than a million minutes of oral argument audio. More than anywhere else on the Internet.",
# RECAP & PACER
Expand Down
37 changes: 12 additions & 25 deletions cl/simple_pages/templates/podcasts.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,12 @@ <h2>How to Subscribe</h2>


<h3>Using a Podcast App</h3>
<div class="row">
<div class="col-xs-12">
<p>Our podcasts are available in a number of music services and apps. To find our podcasts, just search for "CourtListener".
</p>
</div>
<div class="col-xs-1"></div>
<div class="col-xs-2">
<h4 class="text-center text-uppercase gray">iTunes</h4>
<p>
Our podcasts are available in a number of music services and apps. To find our podcasts, just search for "CourtListener".
</p>
<div class="flex justify-content-center" style="flex-wrap: wrap">
<div class="col-sm-2 col-xs-5" style="padding: 15px; max-width: 190px">
<h5 class="text-center text-uppercase gray">iTunes</h5>
<a href="https://www.apple.com/itunes/">
<img src="{% static "png/itunes.png" %}"
alt="iTunes Logo"
Expand All @@ -67,8 +65,8 @@ <h4 class="text-center text-uppercase gray">iTunes</h4>
width="200">
</a>
</div>
<div class="col-xs-2">
<h4 class="text-center text-uppercase gray">Google Music</h4>
<div class="col-sm-2 col-xs-5" style="padding: 15px; max-width: 190px">
<h5 class="text-center text-uppercase gray">Google Music</h5>
<a href="https://play.google.com/music/">
<img src="{% static "svg/play_music_triangle.svg" %}"
alt="Google Play Logo"
Expand All @@ -78,19 +76,8 @@ <h4 class="text-center text-uppercase gray">Google Music</h4>
</a>
</div>

<div class="col-xs-2">
<h4 class="text-center text-uppercase gray">Stitcher Radio</h4>
<a href="https://www.stitcher.com">
<img src="{% static "jpeg/stitcher_400x400.jpeg" %}"
alt="Google Play Logo"
class="img-responsive center-block img-rounded"
height="200"
width="200">
</a>
</div>

<div class="col-xs-2">
<h4 class="text-center text-uppercase gray">Pocket Casts</h4>
<div class="col-sm-2 col-xs-5" style="padding: 15px; max-width: 190px">
<h5 class="text-center text-uppercase gray">Pocket Casts</h5>
<a href="https://pocketcasts.com">
<img src="{% static "png/pocketcasts_200x200.png" %}"
alt="Pocket Casts Logo"
Expand All @@ -100,8 +87,8 @@ <h4 class="text-center text-uppercase gray">Pocket Casts</h4>
</a>
</div>

<div class="col-xs-2">
<h4 class="text-center text-uppercase gray">PlayerFM</h4>
<div class="col-sm-2 col-xs-5" style="padding: 15px; max-width: 190px">
<h5 class="text-center text-uppercase gray">PlayerFM</h5>
<a href="https://player.fm">
<img src="{% static "png/playerfm_200x200.png" %}"
alt="PlayerFM Logo"
Expand Down
Loading