Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate application #62

Closed
freescout-helpdesk opened this issue Sep 26, 2018 · 24 comments
Closed

Translate application #62

freescout-helpdesk opened this issue Sep 26, 2018 · 24 comments
Labels
help wanted Extra attention is needed

Comments

@freescout-helpdesk
Copy link
Contributor

Now you can translate application into other languages. See Translation guide

@freescout-helpdesk freescout-helpdesk added the help wanted Extra attention is needed label Sep 26, 2018
@bohwaz
Copy link

bohwaz commented Nov 15, 2018

OK I started translating to French :) but can't find where I can set the app to use the French language? :(

@freescout-helpdesk
Copy link
Contributor Author

@bohwaz
Copy link

bohwaz commented Nov 15, 2018

Yeah but I would like to see them show up in the app before I send them because I'm not sure of the context of some of the strings, so I need to check and see where they appear to make sure the translation makes sense :)

@freescout-helpdesk
Copy link
Contributor Author

If you are a developer, try to find a way. Otherwise follow instructions.

@bohwaz
Copy link

bohwaz commented Nov 15, 2018

OK then I'm gonna stop there, send the translations and wait that the language implementation is complete to finish them. Cheers.

Edit: sent.

@freescout-helpdesk
Copy link
Contributor Author

Unfortunately we did not receive an email with the archive.
Can you archive /resources/langs folder and attach it to this ticket?

@jfparent
Copy link

fr.zip

small contribution

@bohwaz
Copy link

bohwaz commented Nov 21, 2018

translate_fr.zip

Here is my contrib. The JSON translation is incomplete as I need more context (that's why I would need to preview the translation in the UI) to continue.

@freescout-helpdesk
Copy link
Contributor Author

@bohwaz French language added in FreeScout 1.0.8

@bohwaz
Copy link

bohwaz commented Dec 5, 2018

Awesome, thanks, will try to update it eventually :)

@bohwaz
Copy link

bohwaz commented Dec 5, 2018

Found those translation strings that have errors:

  • assigned :assignee convsersation #:conversation_number
  • Remove non-npublished

@bohwaz
Copy link

bohwaz commented Dec 5, 2018

I am progressing on the translation and I have a few remarks.

I would suggest including the item in the translation string and not splitting the strings as it doesn't really work in other languages.

For example: 1 total conversations | 0 active | Viewing 1-1 appears as 3 strings in the translations: total conversations, active and Viewing.

But depending on the language, the number might be before, after or even inside the string.

I suggest doing instead: :number total conversations, :number active and Viewing :current for example.

The same issue applies to other places, for example in a conversation:

  • you | marked as | Closed
  • you | assigned to | anyone
  • you | started the conversation

because the sentence can have a different order depending on the language you need to put full sentences in the translations, instead of just splitting the sentence like it's done actually (you is a separate string from marked as). A better solution would be:

  • you marked as :new_status
  • :username marked as :new_status
  • you assigned to anyone
  • :username assigned to anyone
  • you assigned to :username
  • :username assigned to :assignee_username
  • you started the conversation
  • :username started the conversation

Another issue is that there doesn't seem to be a way to manage plurals for strings referring to numbers. In French we have two plural forms, but singular is used for zero, in English the plural is used for zero. And in other languages it's even more complex (you can read https://www.gnu.org/savannah-checkouts/gnu/gettext/manual/html_node/Plural-forms.html to have fun).

Thanks!

@bohwaz
Copy link

bohwaz commented Dec 5, 2018

Ah yeah last small issue, special folders names like "Unassigned", "Mine" etc. cannot be translated currently.

@maxmueller89
Copy link

Hey guys,
I just started to translate the main app into German. After a few translations I wanted to check via publish if it worked but nowhere the translation is applied. I followed the guide Translation Guide preciely ..

@freescout-helpdesk
Copy link
Contributor Author

Did you choose German language in your profile?

@maxmueller89
Copy link

Lol thanks you are right. Will do a full German translation within the next two weeks and will submit it to you guys!

@maxmueller89
Copy link

I followed your Translation Guide and was able to translate everything and publish it.

Unfortunately, when I try to share it with the button "Send Translations to Freescout Team" I get the error: Error occured sending translations. Make sure that you have PHP Zip extension enabled and check your mail settings.

My PHP Zip extension is enabled and my mail settings are fine as we are sending daily emails to customers.

When clicking "Download as ZIP" I get the error: Whoops, looks like something went wrong.

Anmerkung 2019-11-26 092419

Any idea?

@freescout-helpdesk
Copy link
Contributor Author

Anything in System --> Logs?

@maxmueller89
Copy link

Nope
Freescout

@freescout-helpdesk
Copy link
Contributor Author

Manage --> Logs

@maxmueller89
Copy link

Nothing unusual I guess ..
Freescout1
Freescout2
Freescout3
Freescout4

@freescout-helpdesk
Copy link
Contributor Author

Most likely application can not create an archive in /storage/app/zipper folder due to some permissions issues. So you can archive and send /resources/lang folder to [email protected]

@globalcow
Copy link

Hi @maxmueller89, I would like to add some corrections to the German translation. I was wondering if you decided to use a formal style ("Sie") or informal ("Du")? It seems the style is a little bit mixed in the moment.

@globalcow
Copy link

Hi @freescout-helpdesk, I just worked on the German translation and fixed many things. However, als @bohwaz already said in #62 (comment), you should change the strings including 'You' and 'Yourself' as suggested by @bohwaz . Otherwise it is impossible to get a grammatically correct translated GUI in German language.
I really love FreeScout and a good translation will be way more professional and will be definitely more appealing to new users!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants