claim staking rewards 1747 | will be split up into multiple PRs #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prototypes, make check working
updates to impl design doc
refinements to design doc
Implement the basic functionality of tracking and rotating Reward Era. Closes #1567 Does not include anything to do with the Reward Pool. - [x] Chain spec updated - [x] Design doc(s) updated - [x] Tests added
The goal of this PR is to implement a really basic version of the StakingRewardsProvider in the Capacity pallet and in the test mock, neither of which is actively used. Closes #1572 Does not include anything to do with setting and storing RewardPoolInfo when each new Era starts. - [x] Design doc(s) updated - [x] Tests added
* Make some functions pass by reference (performance) * fix broken tests & calls
* Performance: move non-db checks to top when retargeting * Lots more tests * Fix a bug where we weren't setting the staking type on a retarget * Remove staking type from StakingAccountDetails * Fix broken tests from last commit
The goal of this PR is to implement storage of reward pool history. Closes #1710
The goal of this PR is to split up storage of boosting and maximized staking accounts, as well as store retarget history separately, which can store retargeting events for any type of staking. Closes #1726 * Lots of rattle, causing several helper functions to be split up - rather than having a bunch of conditionals due to type differences. * In the interest of limiting the size of this PR/merge into the branch I left a lot of TODOs for when reward pool updates on a stake/boost/unstake is resumed
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking. * Also Fixes some tests broken from the last rebase with main. Closes #1569
The goal of this PR is to update the StakingRewardPool on a `provider_boost` or `unstake` extrinsic call. Closes #1699 Also includes a bunch of lint changes - [x] Design doc(s) updated - [x] Tests added - [x] Benchmarks corrected and updated - [x] Weights updated
The goal of this PR is to implement a "chunk" version of the overall reward pool history to reduce read/write load and hence weight for transactions and `on_initialize` when a new `RewardEra` needs to start. Part of #1976 Co-authored-by: Wil Wade <[email protected]>
# Goal The goal of this PR is to review and update the implementation design doc in light of the chosen economic model, and to reflect some changes in behavior. Review of the design doc also fed back into the code itself. Some code is no longer needed. Closes #2016 --------- Co-authored-by: Aramik <[email protected]>
shannonwells
changed the base branch from
main
to
feat/capacity-staking-rewards-impl
shannonwells
changed the title
# Goal The goal of this PR is to add some e2e tests for the `provider_boost` extrinsic, and update the `change_staking_target` extrinsic after a rebase with main.
# Goal The goal of this PR is primarily to pull RewardEra out of the Capacity Config and make it the same type everywhere. Other changes in this PR that were incidental to this refactor * I renamed staking_events in testing_utils, because it captures all the events from the pallet. * I pulled out RewardEraLength into constants so it could be different for different environments. Related to #1970
* Fixes for removing RewardEra from Config (including ctor for RetargetInfo struct) * Set up different values for EraLength in Test and on testnet * Linting changes * Working list_unclaimed_rewards runtime_api call
shannonwells
force-pushed
the
feat/claim_staking_rewards-1747
branch
from
20914f7 to
137daeb
Compare
shannonwells
force-pushed
the
feat/capacity-staking-rewards-impl
branch
from
ad63363 to
ec2b7ac
Compare
|
Finished splitting this up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to implement runtime api for capacity with list_unclamed_rewards function, and to add end to end tests for new extrinsics.
Relates to #1747
Relates to #1972
Discussion
Checklist