Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect Provider Hookup #113

Closed
claireolmstead opened this issue Jan 25, 2024 · 0 comments · Fixed by #131
Closed

Connect Provider Hookup #113

claireolmstead opened this issue Jan 25, 2024 · 0 comments · Fixed by #131
Assignees
@claireolmstead

Comments

@claireolmstead
Copy link
Contributor

As a developer, we wanted to merge the connect provider UI even though it was not hooked up due to blockers.

TODO:

  • add dropdowns
  • add connect functionality onclick of the connect button.

Image
This was referenced Jan 25, 2024
Merged
Closed
Merged
@claireolmstead claireolmstead self-assigned this Jan 30, 2024
@claireolmstead claireolmstead added the blocked Blocked by another issue label Jan 30, 2024
@claireolmstead claireolmstead mentioned this issue Jan 30, 2024
Open
@claireolmstead claireolmstead removed the blocked Blocked by another issue label Feb 1, 2024
@claireolmstead claireolmstead mentioned this issue Feb 8, 2024
Merged
claireolmstead added a commit that referenced this issue Feb 8, 2024
@claireolmstead
113 connect provider hookup (#131)
15258f4 
closes #113 

## Changes
- Created `LoginForm`, a form used in `ConnectProvider` and
`ProviderLogin`.
- Delete placeholder code in favor of `LoginForm` in  `ConnectProvider`.
- Updated `SelectNetworkAndAccount component` variable naming, on value
change functionality, and, and improved disabled state.
- Trickle-down changes: fix state & API updates in `updateApiAndUser`
with updateApiAndUser().
- Updated tests to reflect changes.

## How to test
- Check login
- Check Become A Provider (create MSA & create provider)
- Click on switch button and check Connect Provider modal.
  - switch between networks before and after selecting a key.
  - check cancel works as expected.

## Notes
- auto-populating the connect provider modal "Select a Provider Control
Key" dropdown was not cooperating, so I opted to just make that a null
value and display the placeholder.

---------

Co-authored-by: Claire Olmstead <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claireolmstead claireolmstead

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@claireolmstead