Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

86 connect provider modal #103

Merged
merged 2 commits into from
Jan 25, 2024
Merged

86 connect provider modal #103

merged 2 commits into from
Jan 25, 2024

Conversation

claireolmstead
Copy link
Contributor

@claireolmstead claireolmstead commented Jan 18, 2024 •
edited
Loading

closes #86
blocked by #105

@claireolmstead claireolmstead linked an issue Jan 18, 2024 that may be closed by this pull request
Connect Provider modal #86
Closed
claireolmstead
claireolmstead commented Jan 18, 2024
View reviewed changes
src/components/ConnectProvider.svelte
<Modal {close}>
<div class="flex flex-col gap-7">
<h2 class="section-title-underlined">Connect Provider</h2>
<!-- Select a network dropdown goes here -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rlaferla TODO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODOs to be resolved in #113

@claireolmstead
Copy link
Contributor Author

claireolmstead commented Jan 18, 2024 •
edited
Loading

@rlaferla officially passing this story off to you! Thank you so much. I left some notes on explanations in the comments as well as a note on what is left to do. That last little part is blocked by your current story (#90). Thanks again!

@rlaferla
Copy link
Contributor

@rlaferla officially passing this story off to you! Thank you so much. I left some notes on explanations in the comments as well as a note on what is left to do. That last little part is blocked by your current story (#90). Thanks again!

fyi - You should reassign the issue in GitHub instead of tagging me in the PR.

@claireolmstead claireolmstead force-pushed the 86-connect-provider-modal branch from 2bacd81 to c5b0523 Compare January 25, 2024 21:41
@claireolmstead
Copy link
Contributor Author

claireolmstead commented Jan 25, 2024 •
edited
Loading

@rlaferla officially passing this story off to you! Thank you so much. I left some notes on explanations in the comments as well as a note on what is left to do. That last little part is blocked by your current story (#90). Thanks again!

fyi - You should reassign the issue in GitHub instead of tagging me in the PR.

I originally reassigned it to you, but because you did not end up picking it up when I was gone I re-took ownership and unassigned you. I did the same thing for the related issue. You can see the unassignment in the log above.

@rlaferla
Copy link
Contributor

@rlaferla officially passing this story off to you! Thank you so much. I left some notes on explanations in the comments as well as a note on what is left to do. That last little part is blocked by your current story (#90). Thanks again!

fyi - You should reassign the issue in GitHub instead of tagging me in the PR.

I originally reassigned you but because you did not end up picking this up when I was gone and I re-took ownership of this story I unassigned you. I did the same thing for the related issue. You can see the unassignment in the log above.

It was in the larger PR.

@claireolmstead claireolmstead added the blocked Blocked by another issue label Jan 25, 2024
@claireolmstead
Copy link
Contributor Author

Due to blockers, going to merge this story in with open TODOs. TODOs to be resolved in #113

@claireolmstead claireolmstead merged commit 07e94f5 into main Jan 25, 2024
3 checks passed
@claireolmstead claireolmstead deleted the 86-connect-provider-modal branch January 25, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlaferla rlaferla rlaferla approved these changes

Assignees

@claireolmstead claireolmstead

Labels
blocked Blocked by another issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connect Provider modal
2 participants
@claireolmstead @rlaferla