-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markup isn't handled properly #121
Comments
ad 1): ad 2): One more thing is: any note (=> what else can a markup to attached to? Rests, anything more? How is the relation to marks or tempo indications?) can have multiple markups attached to it (with the same or differing directions). So we have to do a number of things:
|
Closes #121 As described in the Issue the previous implementation of \markup had two flaws: - direction modifier wasn't respected - all markups in a bar would be added as a child of the bar instead of being attached to the notes This commit creates each \markup as a <direction> element immediately preceding the note/rest the markup is attached to. If there's an explicit direction operator it is respected. Multiple markups may be attached to a single note, each with its own direction (or lack thereof). The handling of Markup() and MarkupElement() objects is already prepared to dealing with variable formatting, insofar as a Markup() contains a list of MarkupElement() items, which will later be used to handle formatting. One \markup will generate one <direction> element. This contains a sequence of <words> elements (currently only one), which can individually be assigned formatting attributes.
Closes #121 As described in the Issue the previous implementation of \markup had two flaws: - direction modifier wasn't respected - all markups in a bar would be added as a child of the bar instead of being attached to the notes This commit creates each \markup as a <direction> element immediately preceding the note/rest the markup is attached to. If there's an explicit direction operator it is respected. Multiple markups may be attached to a single note, each with its own direction (or lack thereof). The handling of Markup() and MarkupElement() objects is already prepared to dealing with variable formatting, insofar as a Markup() contains a list of MarkupElement() items, which will later be used to handle formatting. One \markup will generate one <direction> element. This contains a sequence of <words> elements (currently only one), which can individually be assigned formatting attributes.
#103 falls short of properly handling markup in two respects:
I think 2. is harder to fix, especially since the current behaviour seems to be achieved on (some) purpose.
The text was updated successfully, but these errors were encountered: