#121: XML: Properly handle \markup #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #121 As described in the Issue the previous implementation of \markup had two flaws: - direction modifier wasn't respected - all markups in a bar would be added as a child of the bar instead of being attached to the notes This commit creates each \markup as a <direction> element immediately preceding the note/rest the markup is attached to. If there's an explicit direction operator it is respected. Multiple markups may be attached to a single note, each with its own direction (or lack thereof). The handling of Markup() and MarkupElement() objects is already prepared to dealing with variable formatting, insofar as a Markup() contains a list of MarkupElement() items, which will later be used to handle formatting. One \markup will generate one <direction> element. This contains a sequence of <words> elements (currently only one), which can individually be assigned formatting attributes.
uliska
commented
May 7, 2018
| @@ -529,6 +531,12 @@ def UserCommand(self, usercommand): | |||
| self.tupl_span = True | |||
|
|
|||
| def Markup(self, markup): | |||
| self.mediator.new_markup(self.postfix) | |||
|
|
|||
| def MarkupCommand(self, markupCommand): | |||
There was a problem hiding this comment.
These two methods are preparing support for markup formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121
As described in the Issue the previous implementation of \markup
had two flaws:
instead of being attached to the notes
This commit creates each
\markupas a<direction>elementimmediately preceding the note/rest the markup is attached to.
If there's an explicit direction operator it is respected.
Multiple markups may be attached to a single note, each with its own
direction (or lack thereof).
The handling of
Markup()andMarkupElement()objects is already preparedto dealing with variable formatting, insofar as a
Markup()contains a list of
MarkupElement()items, which will later be used to handleformatting. One
\markupwill generate one<direction>element. This containsa sequence of
<words>elements (currently only one) which can individuallybe assigned formatting attributes.