Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Fable to Nagareyama #121

Closed

Conversation

alfonsogarciacaro
Copy link
Contributor

@alfonsogarciacaro alfonsogarciacaro commented Nov 9, 2020

@Shmew I didn't try it yet but I think with Fable 3 we can get rid of the compiler directives to avoid type testing with generics like:

      #if !FABLE_COMPILER
      match g with
      | :? GenerateCont<'a> as g -> GenerateCont<_>.Bind (g.Generator, (fun () -> GenerateCont<_>.Bind (g.Cont(), cont)))
      | _ -> (new GenerateCont<'a>(g, cont) :> AsyncGenerator<'a>)
      #else

@dsyme
Copy link
Contributor

dsyme commented Apr 14, 2021

Some problem with #if here

Error: /home/runner/work/FSharp.Control.AsyncSeq/FSharp.Control.AsyncSeq/src/FSharp.Control.AsyncSeq/AsyncSeq.fs(1749,1): error FS0521: No #endif found for #if or #else [/home/runner/work/FSharp.Control.AsyncSeq/FSharp.Control.AsyncSeq/src/FSharp.Control.AsyncSeq/FSharp.Control.AsyncSeq.fsproj]

@dsyme
Copy link
Contributor

dsyme commented Oct 6, 2021

@alfonsogarciacaro I'm closing this, I think it needs to be re-done

@dsyme dsyme closed this Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants