-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tried to update to Fable 3 #82
Conversation
Hey, sadly i couldn't come up with a good workaround for the byrefs that doesn't obfuscate the code massively (#81) |
Well, my first thought was to rewrite the code which uses byref's without them but looking closer I can see that is no easy task.. We could probably use |
Maybe we could write some helpers that (via ifdef) switch between refs and byref, however that could be quite tricky and using refs in non-fable world severely degrades performance most likely |
I'm not suggesting to use ref's instead of byref's in non-fable world. |
Hey, I just thought that with lots of #ifs the code will get extremely cluttered, that's why I was thinking about something that works for both "backends" |
See also #84 as complementary PR to this one. |
* updated fable tool & packages
@krauthaufen Just to clarify, what Fable version are you compiling with? I was able to compile #84 with latest pre-release Fable 3 without any additional changes required, but it's quite possible that version is not officially released yet. Anyway, that's probably not relevant to your question. Yes, I've noticed the Fable Adaptive test is failing with |
@ncave, I've tried to compile it with Fable 3.1.12 and I'm getting
I've managed to make it compile by replacing let n = defaultValueArg o 0 + op.Count with let n =
match o with
| ValueNone -> op.Count
| ValueSome c -> c + op.Count I hope it's not some sort of a version mismatch (I've noticed that you've just added
|
@pkese Yes, that's expected, support for |
Hey, cool that with all the other PRs Fable support is back on track thanks to @ncave and @delneg Nonetheless when running
When answering yes I get the following error:
I resolved that by running
|
@krauthaufen I'm not sure, but you can just remove it, it's already defined in |
Great work! I'd be happy if someone could help sort out the Fable 3 support for https://github.com/fsprojects/FSharp.Control.AsyncSeq/, e.g. fsprojects/FSharp.Control.AsyncSeq#121 |
Thanks everyone, glad it's merged. |
Hello, I've tried to update Fable in the project to Fable 3
For that I've also included dotnet tools file reference (paket and fable included)
Right now, I'm getting a lot of errors.
You can run the following set of commands to get the same:
Here's the full output I'm getting as of right now: