Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception when custom ID is empty #21

Closed
Clashsoft opened this issue Sep 27, 2020 · 0 comments · Fixed by #22
Closed

Exception when custom ID is empty #21

Clashsoft opened this issue Sep 27, 2020 · 0 comments · Fixed by #22
Assignees
@Clashsoft
Labels
bug Something isn't working
Milestone
v1.4.0

Comments

@Clashsoft
Copy link
Member

This originally occurred in fujaba/fulibScenarios#187, where a fulib FMethod had an empty name property.
@Clashsoft Clashsoft added the bug Something isn't working label Sep 27, 2020
@Clashsoft Clashsoft added this to the v1.4.0 milestone Sep 27, 2020
@Clashsoft Clashsoft self-assigned this Sep 27, 2020
@Clashsoft Clashsoft mentioned this issue Sep 27, 2020
Closed
Clashsoft added a commit that referenced this issue Sep 27, 2020
@Clashsoft
fix: Improve key handling in IdMap
96054dd 
Changed the `IdMap.generateUniqueKey` method to correctly handle empty
custom IDs. It also uses Reflector for accessing the `id` and `name`
properties.

Closes #21
@Clashsoft Clashsoft mentioned this issue Sep 27, 2020
Merged
@Clashsoft Clashsoft linked a pull request Sep 27, 2020 that will close this issue
Improve key handling in IdMap #22
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Clashsoft Clashsoft

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

Improve key handling in IdMap fujaba/fulibYaml
1 participant
@Clashsoft