Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve key handling in IdMap #22

Merged
merged 2 commits into from
Sep 27, 2020
Merged

Improve key handling in IdMap #22

merged 2 commits into from
Sep 27, 2020

Conversation

Clashsoft
Copy link
Member

Bugfixes

Closes #21

@Clashsoft
fix: Improve key handling in IdMap
96054dd 
Changed the `IdMap.generateUniqueKey` method to correctly handle empty
custom IDs. It also uses Reflector for accessing the `id` and `name`
properties.

Closes #21
@Clashsoft Clashsoft added the bug Something isn't working label Sep 27, 2020
@Clashsoft Clashsoft added this to the v1.4.0 milestone Sep 27, 2020
@Clashsoft Clashsoft self-assigned this Sep 27, 2020
@Clashsoft Clashsoft linked an issue Sep 27, 2020 that may be closed by this pull request
Exception when custom ID is empty #21
Closed
@Clashsoft Clashsoft merged commit 61cb5a0 into bugfix Sep 27, 2020
@Clashsoft Clashsoft deleted the fix/21 branch September 27, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Clashsoft Clashsoft

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Exception when custom ID is empty
1 participant
@Clashsoft